Skip to content

Add Notation to TestCheckMasterHealthy in pkg\ddc\alluxio\health_chec…#4617

Merged
cheyang merged 1 commit intofluid-cloudnative:masterfrom
BaideBear:new-lier-branch
Mar 18, 2025
Merged

Add Notation to TestCheckMasterHealthy in pkg\ddc\alluxio\health_chec…#4617
cheyang merged 1 commit intofluid-cloudnative:masterfrom
BaideBear:new-lier-branch

Conversation

@BaideBear
Copy link
Copy Markdown
Contributor

@BaideBear BaideBear commented Mar 11, 2025 •
edited
Loading

Ⅰ. Describe what this PR does
Add Notations for TestCheckMasterHealthy in pkg\ddc\alluxio\health_check_test.go.
Ⅱ. Does this pull request fix one issue?
fixes #4616

@BaideBear
Add Notation to TestCheckMasterHealthy in pkg\ddc\alluxio\health_chec…
edc20c9 
…k_test.go

Signed-off-by: BaideBear <3345180277@qq.com>
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 11, 2025

Hi @BaideBear. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 11, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
100.0% Duplication on New Code

See analysis details on SonarQube Cloud

@BaideBear
Copy link
Copy Markdown
Contributor Author

BaideBear commented Mar 14, 2025

/assign @zwwhdls

cheyang
cheyang approved these changes Mar 17, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot Bot added the lgtm label Mar 17, 2025
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang
Copy link
Copy Markdown
Collaborator

cheyang commented Mar 18, 2025

/ok-to-test

@cheyang cheyang merged commit 8a89517 into fluid-cloudnative:master Mar 18, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheyang cheyang cheyang approved these changes

Assignees

@cheyang cheyang

@zwwhdls zwwhdls

Labels

approved lgtm ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add comments to TestCheckMasterHealthy in pkg\ddc\alluxio\health_check_test.go .

3 participants

@BaideBear @cheyang @zwwhdls